-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update k8s version #1701
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1701 +/- ##
==========================================
- Coverage 84.34% 84.13% -0.21%
==========================================
Files 151 150 -1
Lines 9601 9577 -24
==========================================
- Hits 8098 8058 -40
- Misses 1218 1233 +15
- Partials 285 286 +1
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
SonarCloud Quality Gate failed.
|
30e866f
to
0b006f2
Compare
envtest uses the env var ENVTEST_K8S_VERSION this is currently too old 1.24 and needs to be updated to 1.27.0 or more |
98eabca
to
ce0342b
Compare
I do not think it is a good strategy to change the code to make the test pass, instead of removing Status().Update() we can fix our usage of the fake client adding the object at client creation and making sure to use .WithStatusSubresource(objs...) I fixed this for the app version and changed the app version tests but we should do all of them this fixed appversion failing component test, so the change should make all component test pass |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
ccfee8d
to
a7f579d
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed!
|
This Fixes #1445 Closes #1457
A big breaking change has been added to fakeclient kubernetes-sigs/controller-runtime#2259
where basically any resource where we want to update the status should be prevetively added by the test at client generation using the WithStatusSubresource option. This pr fixes parts of it, but many tests in which we use fakeclient.create() in the lifecycle controller will need an update